Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [RFC] Add Unmanaged Launch Template Removal RFC #4211

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jul 6, 2023

Fixes #N/A

Description

This PR adds a RFC design doc recommending that Karpenter drop the spec.launchTemplateName field from the new v1beta1/EC2NodeClass and provides the rationale behind the decision, including alternative options.

How was this change tested?

N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 2d762e9
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64ab285239b75e0008cf244d

@jonathan-innis jonathan-innis force-pushed the rfc-unmanaged-launch-template-removal branch 2 times, most recently from 3365292 to 32b5d4e Compare July 6, 2023 07:21
@sftim
Copy link
Contributor

sftim commented Jul 6, 2023

If we want to support custom launch templates, I would add a whole new custom resource, eg AWSCustomNodeTemplate. For example, we could have that as beta-grade, tested, best-effort code and an alpha API version.

To highlight the alpha state, bump the alpha API version every n months and deprecate old-enough alpha APIs.

@jonathan-innis jonathan-innis force-pushed the rfc-unmanaged-launch-template-removal branch from 32b5d4e to ef4825c Compare July 6, 2023 21:53
@jonathan-innis
Copy link
Contributor Author

I would add a whole new custom resource

This is a really interesting idea. If we had enough users doing this, I could imagine us doing something like this. This at least draws the line better between the two concepts so that we don't have two api concepts that have different incompatibilities with each other that make it hard to reason about.

@jonathan-innis jonathan-innis force-pushed the rfc-unmanaged-launch-template-removal branch from ef4825c to 2d762e9 Compare July 9, 2023 21:36
@github-actions
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis jonathan-innis added needs-review PRs that are still going through the review process and removed lifecycle/stale labels Jul 25, 2023
@jonathan-innis jonathan-innis marked this pull request as ready for review July 25, 2023 18:51
@jonathan-innis jonathan-innis requested a review from a team as a code owner July 25, 2023 18:51
@jonathan-innis jonathan-innis enabled auto-merge (squash) September 15, 2023 07:16
@jonathan-innis jonathan-innis merged commit 17fc308 into aws:main Sep 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review PRs that are still going through the review process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants