Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Compatibility Matrix for karpenter #4401

Merged
merged 1 commit into from
Sep 15, 2023
Merged

chore: Compatibility Matrix for karpenter #4401

merged 1 commit into from
Sep 15, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Aug 8, 2023 •
edited

Fixes #3924, kubernetes-sigs/karpenter#388

Description

  • Building a compatibility matrix to give users context into the supported k8s version for each karpenter release
  • Produce an error for users on incompatible versions
  • Automation to add new karpenter to our compatibility table

How was this change tested?

  • N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Aug 8, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 544dd21
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6504c25f6363b30008cec39f

engedaam
engedaam commented Aug 8, 2023
View reviewed changes
Copy link
Contributor Author

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@engedaam engedaam changed the title docs: Compatibility Matrix docs: Compatibility Matrix for karpenter upgrade Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-40b685b5647345cc74645dacb7a7dd14be56fc6d. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@engedaam engedaam marked this pull request as ready for review August 9, 2023 19:28
@engedaam engedaam requested a review from a team as a code owner August 9, 2023 19:28
@engedaam engedaam requested a review from tzneal August 9, 2023 19:28
@engedaam engedaam force-pushed the compatibility_matrix branch 11 times, most recently from 6ef8456 to caf8043 Compare September 6, 2023 21:24
@engedaam engedaam changed the title docs: Compatibility Matrix for karpenter upgrade chore: Compatibility Matrix for karpenter upgrade Sep 6, 2023
@engedaam engedaam changed the title chore: Compatibility Matrix for karpenter upgrade chore: Compatibility Matrix for karpenter Sep 6, 2023
jonathan-innis
jonathan-innis reviewed Sep 6, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
bwagner5
bwagner5 reviewed Sep 7, 2023
View reviewed changes
hack/docsgen.sh Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the compatibility_matrix branch 2 times, most recently from b85c166 to abc6ea3 Compare September 8, 2023 16:43
@engedaam engedaam force-pushed the compatibility_matrix branch 4 times, most recently from f96c005 to e3cb59d Compare September 8, 2023 22:09
@engedaam engedaam force-pushed the compatibility_matrix branch 6 times, most recently from 9a5eefd to d997d05 Compare September 14, 2023 18:20
jonathan-innis
jonathan-innis reviewed Sep 14, 2023
View reviewed changes
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
hack/code/version_compatibility.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work here! This is going to be great to have for users!

cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
cmd/controller/main.go Outdated Show resolved Hide resolved
hack/code/version_compatibility.go Outdated Show resolved Hide resolved
hack/code/version_compatibility.go Outdated Show resolved Hide resolved
hack/code/version_compatibility.go Outdated Show resolved Hide resolved
hack/docgen.sh Show resolved Hide resolved
hack/docs/compatibilitymetrix_gen_docs.go Show resolved Hide resolved
@engedaam engedaam force-pushed the compatibility_matrix branch 3 times, most recently from ceba3a5 to 60f721f Compare September 15, 2023 18:06
jonathan-innis
jonathan-innis reviewed Sep 15, 2023
View reviewed changes
hack/docs/version_compatibility.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
pkg/operator/operator.go Outdated Show resolved Hide resolved
@engedaam engedaam force-pushed the compatibility_matrix branch 2 times, most recently from 87a28ec to 3b494c7 Compare September 15, 2023 19:38
@engedaam engedaam force-pushed the compatibility_matrix branch 3 times, most recently from aacb9ed to e4b0593 Compare September 15, 2023 20:08
jonathan-innis
jonathan-innis approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit c73bb90 into aws:main Sep 15, 2023
13 checks passed
@engedaam engedaam deleted the compatibility_matrix branch September 15, 2023 20:56
@engedaam engedaam mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 left review comments

@sftim sftim sftim left review comments

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Karpenter docs should include a compatibility matrix with Karpenter/K8s/EKS versions.
4 participants
@engedaam @bwagner5 @sftim @jonathan-innis