-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow specifying root volume in block device mappings #4457
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Chatted on slack. Will join community meeting Aug 31 to discuss |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
We'll have to make sure to add the conversion logic for the |
Hi Jonathan, I didn't see provider in |
You'll have to rebase. I think that this branch is based off an older commit so the v1beta1 changes are not in there yet. I'm also fine to just apply these changes to the v1beta1 APIs rather than supporting both v1alpha1 and v1beta1. This is going to be the place for all of our new features going forward so it might make sense for this to just go there if the conversion changes are too much. Happy to help in any way that's useful with this! Feel free to reach out to me on Slack! |
432e382
to
50c365b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to |
Fixes #3962
Description
RootVolume
flag to theBlockDeviceMapping
, enabling Karpenter to utilize the configured volume size for pod packing.How was this change tested?
Unit tests.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.