Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow specifying root volume in block device mappings #4457

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

luohao
Copy link
Contributor

@luohao luohao commented Aug 19, 2023

Fixes #3962

Description

  • Karpenter doesn't support specifying root volumes within block device mappings. This update introduces a RootVolume flag to the BlockDeviceMapping, enabling Karpenter to utilize the configured volume size for pod packing.

How was this change tested?
Unit tests.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@luohao luohao requested a review from a team as a code owner August 19, 2023 00:35
@luohao luohao requested a review from tzneal August 19, 2023 00:35
@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 50c365b
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/650b3a1b4418200008ef81b6
😎 Deploy Preview https://deploy-preview-4457--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@luohao luohao changed the title Allow specifying root volume in block device mappings fix: Allow specifying root volume in block device mappings Aug 19, 2023
@bwagner5
Copy link
Contributor

Chatted on slack. Will join community meeting Aug 31 to discuss

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis
Copy link
Contributor

We'll have to make sure to add the conversion logic for the v1beta1 APIs when this feature goes in.

@luohao
Copy link
Contributor Author

luohao commented Sep 18, 2023

We'll have to make sure to add the conversion logic for the v1beta1 APIs when this feature goes in.

Hi Jonathan, I didn't see provider in v1beta1 directory. Can you point me to the API or the conversion code?

@jonathan-innis
Copy link
Contributor

jonathan-innis commented Sep 19, 2023

We'll have to make sure to add the conversion logic for the v1beta1 APIs when this feature goes in.

Hi Jonathan, I didn't see provider in v1beta1 directory. Can you point me to the API or the conversion code?

You'll have to rebase. I think that this branch is based off an older commit so the v1beta1 changes are not in there yet. I'm also fine to just apply these changes to the v1beta1 APIs rather than supporting both v1alpha1 and v1beta1. This is going to be the place for all of our new features going forward so it might make sense for this to just go there if the conversion changes are too much. Happy to help in any way that's useful with this! Feel free to reach out to me on Slack!

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-50c365bf3788cc399613e69d527a9ef5de960ec8. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis merged commit acba7a9 into aws:main Sep 21, 2023
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom-AL2 amiFamily or make ephemeral storage block-device explicit
4 participants