chore: Add conversion from v1beta1/NodeClass to v1alpha1/AWSNodeTemplate
#4541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
force-pushed
the
v1beta1-nodetemplate-conversion
branch
from
b8fba4f
to
a2b9c15
Compare
jonathan-innis
changed the title
v1beta1/NodeClass to v1alpha5/AWSNodeTemplate`v1beta1/NodeClass to v1alpha1/AWSNodeTemplate`
jonathan-innis
changed the title
v1beta1/NodeClass to v1alpha1/AWSNodeTemplate`v1beta1/NodeClass to v1alpha1/AWSNodeTemplate
jonathan-innis
force-pushed
the
v1beta1-nodetemplate-conversion
branch
6 times, most recently
from
aa169a2
to
0b1b59f
Compare
jonathan-innis
force-pushed
the
v1beta1-nodetemplate-conversion
branch
from
0b1b59f
to
9563495
Compare
njtran
reviewed
Sep 1, 2023
njtran
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
Adds conversion from a
v1beta1/NodeClassto av1alpha5/AWSNodeTemplatefor the controller and hash annotation handling. This allows the business logic for the controllers and the CloudProvider to only be written with thev1beta1APIs in mind.How was this change tested?
make presubmitDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.