Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cloudformation describe stack step on create cluster failure #4556

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

aman0408
Copy link
Contributor

@aman0408 aman0408 commented Sep 4, 2023

Fixes #4467

Description
Added a new step in E2E test workflow to describe cloudformation stack events on failure to "create eks cluster" step. This will enable us to view the failure reason in the logs itself.

How was this change tested?
Ran E2E workflow while ensuring the create eks cluster step failed. Also tried creating a dummy ec2 stack creation and made it fail.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aman0408 aman0408 requested a review from a team as a code owner September 4, 2023 21:49
@aman0408 aman0408 requested a review from njtran September 4, 2023 21:49
@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 271dd11
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64fa680e4ce06600081e705f

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 Just one nit

.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis previously approved these changes Sep 7, 2023
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis dismissed their stale review September 7, 2023 22:31

One more change requested

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-271dd1195b834eca7ba280a09ff8dc25596dc801. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis enabled auto-merge (squash) September 8, 2023 17:56
@jonathan-innis jonathan-innis merged commit dc0e340 into aws:main Sep 8, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run aws cloudformation describe-stack-events on a Create Cluster failure in E2E
2 participants