-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cloudformation describe stack step on create cluster failure #4556
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
website/content/en/preview/getting-started/getting-started-with-karpenter/createec2.yaml
Outdated
Show resolved
Hide resolved
bf25606
to
8a7d632
Compare
8a7d632
to
4feabad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🎉 Just one nit
41d7f4f
to
5fcaa59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
533db64
to
271dd11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to |
Fixes #4467
Description
Added a new step in E2E test workflow to describe cloudformation stack events on failure to "create eks cluster" step. This will enable us to view the failure reason in the logs itself.
How was this change tested?
Ran E2E workflow while ensuring the create eks cluster step failed. Also tried creating a dummy ec2 stack creation and made it fail.
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.