docs: add workaround for ServiceCIDR setting for windows #4573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jonathan-innis
force-pushed
the
windows-service-cidr
branch
from
46d7eff
to
cb877f7
Compare
tzifudzi
reviewed
Sep 6, 2023
tzifudzi
reviewed
Sep 6, 2023
|
@jzhn When you make the changes from the review, can you make sure to propagate the changes to all the versions that were added to this PR so the change propagates across versions? Thanks! |
|
Thanks for this workaround @jzhn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4088
Description
How was this change tested?
Test setup:
Windows_Server-2019-English-Core-EKS_Optimized-1.27-2023.08.1710.x.0.0/1610.100.0.0/16(not overlapping with VPC)Before workaround:
172.20.0.0/16is set as ServiceCIDRAfter workaround:
10.100.0.0/16is set as ServiceCIDRDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.