-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add instance profile generation for v1beta1/NodeClass
#4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod canceled.
|
jonathan-innis
force-pushed
the
add-role-support
branch
11 times, most recently
from
September 19, 2023 17:00
3e9e39a
to
fd2e401
Compare
jonathan-innis
force-pushed
the
add-role-support
branch
from
September 19, 2023 17:02
fd2e401
to
d460996
Compare
njtran
reviewed
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have some questions about how we're planning on managing these instance profiles now.
jonathan-innis
force-pushed
the
add-role-support
branch
13 times, most recently
from
September 20, 2023 17:01
0c44b43
to
b8c45d6
Compare
jonathan-innis
force-pushed
the
add-role-support
branch
3 times, most recently
from
September 21, 2023 22:01
709d349
to
0326131
Compare
jonathan-innis
force-pushed
the
add-role-support
branch
3 times, most recently
from
September 22, 2023 07:18
f0d20e5
to
09132d8
Compare
jonathan-innis
force-pushed
the
add-role-support
branch
9 times, most recently
from
September 22, 2023 18:37
aa181d0
to
a7c4fad
Compare
jonathan-innis
force-pushed
the
add-role-support
branch
from
September 22, 2023 18:37
a7c4fad
to
ca7ea61
Compare
njtran
reviewed
Sep 22, 2023
jonathan-innis
force-pushed
the
add-role-support
branch
from
September 22, 2023 19:26
d669b58
to
fac8cbc
Compare
ellistarn
reviewed
Sep 22, 2023
jonathan-innis
force-pushed
the
add-role-support
branch
from
September 22, 2023 19:37
fac8cbc
to
edf76d8
Compare
njtran
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This change adds instance profile generation when specifying a role in the
v1beta1/NodeClass
. This will not change the ways that instance profiles can be specified with thev1alpha5/Provisioner
.Starting in
v1beta1
, you will be required to specify a role in yourEC2NodeClass
likeKarpenter will provision an instance profile that uses this role and propagate that profile into the
EC2NodeClass
statusTo ensure that instances that are using this instance profile are able to safely terminate, we now enforce that any
v1beta1/NodeClaim
that is using theEC2NodeClass
must be removed before theEC2NodeClass
will remove the instance profile and terminate. You can view this through the eventing logic likeHow was this change tested?
make presubmit
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.