Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include a Tool for generating Kubernetes compatibility matrix #4580

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Sep 7, 2023

Fixes #N/A

Description

How was this change tested?

  • Manually tested

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner September 7, 2023 18:34
@engedaam engedaam requested a review from njtran September 7, 2023 18:34
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d7dde96
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64fa5424be0ed1000861b0c7

jonathan-innis
jonathan-innis previously approved these changes Sep 7, 2023
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one optional comment

tools/kompat/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit 4424a80 into aws:main Sep 7, 2023
13 checks passed
@engedaam engedaam deleted the include-compatibility-matrix branch September 7, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants