Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow user-data mime content-type before mime-version header #4584

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: allow user-data mime content-type before mime-version header #4584

merged 1 commit into from
Sep 7, 2023

Conversation

bwagner5
Copy link
Contributor

@bwagner5 bwagner5 commented Sep 7, 2023

Fixes #N/A
#4581

Description

  • Allow a mime formatted user-data to have the Content-Type header before the MIME-Version header since both are valid.

How was this change tested?

  • Added suite test and tested on EKS cluster

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner September 7, 2023 21:41
@netlify
Copy link

netlify bot commented Sep 7, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 521aa7e
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64fa4372c3e7f6000879b0eb

engedaam
engedaam approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bwagner5 bwagner5 merged commit a90c158 into aws:main Sep 7, 2023
13 checks passed
@bwagner5 bwagner5 deleted the mime-ident branch September 7, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engedaam engedaam engedaam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwagner5 @engedaam