Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix some misses in v1beta1 migration #4605

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This PR fixes a few misses in the v1beta1 migration that enable NodeClaim launching to succeed

How was this change tested?

  • make presubmit
  • Manual creation of NodeClaim

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b1ac97d
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64ff40e71bbd52000840452c

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 065eb27 into aws:main Sep 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants