Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add core v1beta1 defaulting webhooks #4606

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This changes adds v1beta1 Defaulting webhooks for the NodePool and NodeClaim resources

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a4fc759
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/64ff4902bb5a07000856a946

@jonathan-innis jonathan-innis enabled auto-merge (squash) September 11, 2023 16:53
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-100d378c1196317ca0dc435e4c3d4448b865eef8. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis changed the title chore: Add v1beta1 webhooks chore: Add core v1beta1 webhooks Sep 11, 2023
@jonathan-innis jonathan-innis changed the title chore: Add core v1beta1 webhooks chore: Add core v1beta1 defaulting webhooks Sep 11, 2023
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathan-innis jonathan-innis merged commit 8ed205e into aws:main Sep 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants