New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add imageID status field #4637
Conversation
…ookup launch template versions
✅ Deploy Preview for karpenter-docs-prod canceled.
|
website/content/en/docs/getting-started/getting-started-with-karpenter/cloudformation.yaml
Outdated
Show resolved
Hide resolved
website/content/en/docs/getting-started/getting-started-with-karpenter/cloudformation.yaml
Outdated
Show resolved
Hide resolved
…mplate is in use. Consolidate launch template related data into a struct
…w that we do not need to use this api
as this change depends on the status field of node claim supporting ImageID which requires an update to karpenter-core (to be accomplished by: kubernetes-sigs/karpenter#559) I expect tests to fail until that is merged and go.mod is updated accordingly |
…add ImageID as a .Status field of nodeclaim kind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
Snapshot successfully published to |
…eID… (aws#559) Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> Co-authored-by: Jonathan Innis <joinnis@amazon.com>
feat: Add karpenter.k8s.aws/instance-ami-id label
Fixes #4372
Description
Add the karpenter.k8s.aws/instance-ami-id label to nodes via retrieval of ami-id value from feet override reponse
- We seem to only create ‘instant’ fleets, so this will work for now - https://github.com/aws/karpenter/blob/2dfebc9602a9bf6848616fb3740c0f25a455d650/pkg/providers/instance/instance.go#L209-L209
How was this change tested?
requirement for label added to unit tests, also verified by running my against my own eks cluster and seeing that the node labels are indeed added to provisioned nodes appropriately (either via nodes provisioned by karpenter auto-generated launch templates, or via a pre-defined launch template set in aws node template)
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.