Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Sanitize user-controlled variable. #4651

Merged
merged 1 commit into from
Sep 20, 2023
Merged

ci: Sanitize user-controlled variable. #4651

merged 1 commit into from
Sep 20, 2023

Conversation

AdnaneKhan
Copy link
Contributor

Description

This is a minor fix to one of the GitHub Actions workflows. It is a security best practice to sanitize any GitHub Actions variables that can contain arbitrary values in a run step.

How was this change tested?

N/A

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AdnaneKhan AdnaneKhan requested a review from a team as a code owner September 19, 2023 20:35
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 1786529
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/650a062236f9f30008ec4992

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good catch.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://public.ecr.aws/karpenter/karpenter:v0-17865293207a96a39af03d750ea8511a872ce431. Find the image tag and installation instructions at https://gallery.ecr.aws/karpenter/karpenter/

@jonathan-innis jonathan-innis merged commit 094f996 into aws:main Sep 20, 2023
24 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants