Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add v1beta1/EC2NodeClass instance testing for cloudprovider #4670

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This PR adds testing for the cloudprovider instance provider for the v1beta1/EC2NodeClass APIs

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit eb5a8e8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/650c88587a95510008222dc4

@jonathan-innis jonathan-innis changed the title Add v1beta1/EC2NodeClass instance testing for cloudprovider test: Add v1beta1/EC2NodeClass instance testing for cloudprovider Sep 21, 2023
@jonathan-innis jonathan-innis enabled auto-merge (squash) September 21, 2023 17:57
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 9bf86c1 into aws:main Sep 21, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants