Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update NodeClassReference to have fieldname nodeClassRef #4741

Merged
merged 1 commit into from Oct 3, 2023

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Update NodeClassReference to have fieldname nodeClassRef instead of nodeClass to show the field is a reference field

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 3, 2023 15:18
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 59bd408
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/651c30b75c1215000881306b

@jonathan-innis jonathan-innis changed the title choreL: Update NodeClassReference to have fieldname 'nodeClassRef' chore: Update NodeClassReference to have fieldname 'nodeClassRef' Oct 3, 2023
@jonathan-innis jonathan-innis changed the title chore: Update NodeClassReference to have fieldname 'nodeClassRef' chore: Update NodeClassReference to have fieldname nodeClassRef Oct 3, 2023
@jonathan-innis jonathan-innis enabled auto-merge (squash) October 3, 2023 15:21
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit c91f091 into aws:main Oct 3, 2023
12 checks passed
@jonathan-innis jonathan-innis deleted the update-node-class-ref-name branch October 3, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants