Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core to get new termination singleton controller #4754

Merged
merged 3 commits into from Oct 6, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Oct 5, 2023

Fixes #N/A

Description

How was this change tested?
Using this to test through snapshots.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner October 5, 2023 21:11
@njtran njtran requested a review from engedaam October 5, 2023 21:11
Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit a27c394
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/652043998850950008281009
😎 Deploy Preview https://deploy-preview-4754--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-bb7a3c2bc5525baf65d5c19f9d7666523f6b9fa1.

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor Author

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-a27c3947e9a43d957a21444c9c4f8cafbe5b169d.

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 27ad171 into aws:main Oct 6, 2023
22 of 25 checks passed
@njtran njtran deleted the async-update branch December 26, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants