Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add more detail on removing CRDs and removing the IAM policy #4871

Merged

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Oct 20, 2023

Fixes #N/A

Description

This PR adds more detail to the cleanup story, post-migration so that users cleanup their alpha CRDs and the policy on the controller role associated with the alpha APIs.

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner October 20, 2023 20:46
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 6a2b257
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6532f2bccdbab40007d32c18
😎 Deploy Preview https://deploy-preview-4871--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonathan-innis jonathan-innis force-pushed the update-v1beta1-migration-path branch 9 times, most recently from 9f4a797 to 3d7f935 Compare October 20, 2023 21:31
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 24cd55c into aws:main Oct 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants