Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix env vars for v1beta1 controller policy #4909

Merged
merged 1 commit into from Oct 24, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Oct 24, 2023

Fixes #N/A

Description
The guide sets the AWS_REGION variable, not the REGION variable

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner October 24, 2023 19:33
@njtran njtran requested a review from ellistarn October 24, 2023 19:33
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 6997222
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65381c0f497e40000824e664
😎 Deploy Preview https://deploy-preview-4909--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@njtran njtran enabled auto-merge (squash) October 24, 2023 19:41
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🎉

@njtran njtran merged commit 0511f5d into aws:main Oct 24, 2023
11 checks passed
@njtran njtran deleted the v1beta1-cfn branch December 26, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants