Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove GITHUB_ENV in favor of GITHUB_OUTPUT #4926

Merged
merged 1 commit into from Oct 25, 2023
Merged

chore: Remove GITHUB_ENV in favor of GITHUB_OUTPUT #4926

merged 1 commit into from Oct 25, 2023

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Oct 25, 2023 •
edited

Fixes #N/A

Description

Swap GITHUB_ENV with GITHUB_OUTPUT

How was this change tested?

🙏

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ellistarn ellistarn requested a review from a team as a code owner October 25, 2023 17:47
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 967fd35
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/653954a9c3069a0008fcb927

jonathan-innis
jonathan-innis approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ellistarn ellistarn enabled auto-merge (squash) October 25, 2023 19:11
@ellistarn ellistarn merged commit 93484b9 into aws:main Oct 25, 2023
12 checks passed
@ellistarn ellistarn deleted the env branch October 25, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ellistarn @jonathan-innis