Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Drop comma-delimited-list on tags for subnetSelectorTerms, securityGroupSelectorTerms, and amiSelectorTerms #5220

Merged
merged 1 commit into from
Dec 5, 2023
Merged

BREAKING CHANGE: Drop comma-delimited-list on tags for subnetSelectorTerms, securityGroupSelectorTerms, and amiSelectorTerms #5220

merged 1 commit into from
Dec 5, 2023

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 4, 2023

Fixes #5219

Description
Dropping support for comma-delimited lists on subnetSelectorTerms, securityGroupTerms, and amiSelectorTerms.

Users will now need to specify each tag key and value for all tags that may start with the same key

Before

 amiSelectorTerms:
    - test-1: "ami-name1,ami-name2"

After

 amiSelectorTerms:
    - test-1: "ami-name1"
    - test-1: "ami-name2"

How was this change tested?

  • make presubmit and /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner December 4, 2023 19:50
@engedaam engedaam requested a review from jmdeal December 4, 2023 19:50
@netlify Netlify
Copy link

netlify bot commented Dec 4, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 46e6cfb
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/656e686c915c3f00083b4076
😎 Deploy Preview https://deploy-preview-5220--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@engedaam engedaam changed the title BREAKING CHANGE: Drop comma-delimited-list on tags for subnetSelectorTerms, securityGroupSelectorTerms, and amiSelectorTerms BREAKING CHANGE: Drop comma-delimited-list on tags for subnetSelectorTerms, securityGroupSelectorTerms, and amiSelectorTerms Dec 4, 2023
jonathan-innis
jonathan-innis approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit fbdb621 into aws:main Dec 5, 2023
12 checks passed
@engedaam engedaam deleted the drop-comma-delimited-list branch December 5, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jmdeal jmdeal Awaiting requested review from jmdeal jmdeal is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Support for Comma-Delimited List on Tags for Selectors
2 participants
@engedaam @jonathan-innis