Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: expanded storage integration tests #5229

Merged
merged 2 commits into from Dec 8, 2023
Merged

test: expanded storage integration tests #5229

merged 2 commits into from Dec 8, 2023

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Dec 5, 2023 •
edited

Fixes #N/A

Description
This PR expands upon the existing storage integration tests in light of kubernetes-sigs/karpenter#783.

How was this change tested?
make e2etest

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner December 5, 2023 01:32
@jmdeal jmdeal requested a review from bwagner5 December 5, 2023 01:32
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ee520f7
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6572273473863f0008b9956b

@jmdeal jmdeal force-pushed the pv-integration-tests branch 3 times, most recently from 46e7269 to 2f18228 Compare December 5, 2023 18:07
jmdeal
jmdeal commented Dec 5, 2023
View reviewed changes
Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Snapshot successfully published to oci://071440425669.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:v0-2f18228cd676f0fd31409978eb2027e1d8154eee.

@jmdeal jmdeal force-pushed the pv-integration-tests branch 5 times, most recently from e2dba2c to 740a1af Compare December 6, 2023 00:22
jonathan-innis
jonathan-innis reviewed Dec 6, 2023
View reviewed changes
test/suites/integration/storage_test.go Outdated Show resolved Hide resolved
test/suites/integration/storage_test.go Outdated Show resolved Hide resolved
test/suites/integration/storage_test.go Outdated Show resolved Hide resolved
test/suites/integration/storage_test.go Show resolved Hide resolved
test/suites/integration/storage_test.go Show resolved Hide resolved
test/suites/integration/storage_test.go Show resolved Hide resolved
test/suites/integration/storage_test.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 6, 2023 •
edited

Pull Request Test Coverage Report for Build 7133478193

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.489%
Totals Coverage Status
Change from base Build 7132643705: 0.0%
Covered Lines: 4918
Relevant Lines: 5962
💛 - Coveralls

jonathan-innis
jonathan-innis previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here 🎉

test/suites/integration/storage_test.go Show resolved Hide resolved
@jonathan-innis jonathan-innis mentioned this pull request Dec 7, 2023
Merged
jonathan-innis
jonathan-innis approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit a3c0dfc into aws:main Dec 8, 2023
12 checks passed
This was referenced Dec 14, 2023
Closed
Closed
@jmdeal jmdeal deleted the pv-integration-tests branch May 9, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmdeal @coveralls @jonathan-innis