Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Convert CDL values on tags for SelectorTerms #5230

Closed
wants to merge 1 commit into from
Closed

chore: Convert CDL values on tags for SelectorTerms #5230

wants to merge 1 commit into from

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Dec 5, 2023

Fixes #N/A

Description

  • Convert CDL values on tags into multiple selectors
  • This will affect subnet, security group, and AMI selectors

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner December 5, 2023 02:04
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2023 •
edited

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 4e10461
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/656ebcf1fbbaa80008d18450

@engedaam engedaam force-pushed the seprate-CDL-tags-into-selectors branch 3 times, most recently from 391f663 to fa32af2 Compare December 5, 2023 04:17
jonathan-innis
jonathan-innis reviewed Dec 5, 2023
View reviewed changes
pkg/utils/nodeclass/nodeclass.go Outdated Show resolved Hide resolved
pkg/utils/nodeclass/nodeclass.go Outdated Show resolved Hide resolved
pkg/utils/nodeclass/nodeclass.go Show resolved Hide resolved
pkg/utils/nodeclass/nodeclass.go Outdated Show resolved Hide resolved
pkg/utils/nodeclass/nodeclass.go Outdated Show resolved Hide resolved
pkg/utils/nodeclass/nodeclass.go Show resolved Hide resolved
@engedaam engedaam force-pushed the seprate-CDL-tags-into-selectors branch 2 times, most recently from ecc5d1f to 034596c Compare December 5, 2023 05:47
@engedaam engedaam force-pushed the seprate-CDL-tags-into-selectors branch from 034596c to 4e10461 Compare December 5, 2023 06:02
@engedaam engedaam changed the base branch from main to release-v0.32.x December 5, 2023 18:53
@engedaam engedaam changed the base branch from release-v0.32.x to main December 5, 2023 18:54
@engedaam engedaam closed this Dec 5, 2023
@engedaam engedaam deleted the seprate-CDL-tags-into-selectors branch December 5, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@engedaam @jonathan-innis