Build and Host Website on Netlify #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellistarn
previously approved these changes
Jul 22, 2021
|
Looks great to me! I appreciate that with this strategy we won't need to worry about the Hugo generated HTML in the repo. |
|
Rebased off |
geoffcline
approved these changes
Jul 23, 2021
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue, if available:
N/A
Description of changes:
After wrestling with Github Pages for the last 24 hours, and failing to get it to play nicely with Karpenter's monorepo structure and Hugo, I propose we build and host the docs site on Netlify. Over time we can evolve this approach as needed, but for the near term, I believe this is good solution for the project.
This PR includes two changes, first is a
netlify.tomlconfig file that is essentially copied from the Hugo Netlify docs. The second change is a minor change to the Hugo configuration file to simplify thebaseURLand remove thepublishDiras its no longer needed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.