Comprehensive logging improvements #535
Conversation
| - get | ||
| - list | ||
| - watch | ||
| - apiGroups: [""] |
There was a problem hiding this comment.
Is there a reason you changed the format on this one, but not any of the others in this file?
There was a problem hiding this comment.
I think it's a lot easier to read when condensed like this. It's following the tekton/knative projects' example.
There was a problem hiding this comment.
Could you change the rest of the file to match this format?
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 2946ba0 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/60ff1b3542c0580008769174 |
ellistarn
force-pushed
the
logging
branch
10 times, most recently
from
007373f
to
55e7e41
Compare
ellistarn
force-pushed
the
logging
branch
2 times, most recently
from
655c2ef
to
c59ce1a
Compare
| @@ -43,7 +43,6 @@ licenses: ## Verifies dependency licenses and requires GITHUB_TOKEN to be set | |||
| golicense hack/license-config.hcl karpenter | |||
|
|
|||
| apply: ## Deploy the controller into your ~/.kube/config cluster | |||
| kubectl create ns karpenter || true | |||
| helm template karpenter charts/karpenter --namespace karpenter \ | |||
There was a problem hiding this comment.
don't we need --create-namespace for a fresh install to work?
There was a problem hiding this comment.
This workflow assumes that the namespace isn't created or deleted. I think it's much safer to just assume that the developer manages this namespace since there are so many ways it could be created (helm, eksctl, etc) that have bitten us. Worst case, a new dev needs to run kubectl create namespace karpenter
Issue, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.