add step for tagging subnets #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 20f6366 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/60fb46ce66d71e000814b02c 😎 Browse the preview: https://deploy-preview-543--karpenter-docs-prod.netlify.app |
ellistarn
reviewed
Jul 23, 2021
ellistarn
reviewed
Jul 23, 2021
ellistarn
reviewed
Jul 23, 2021
ellistarn
reviewed
Jul 23, 2021
akestner
reviewed
Jul 23, 2021
There was a problem hiding this comment.
Echoed @ellistarn's changes as suggestions to make it easy to update
Co-authored-by: Alex Kestner <akestner@users.noreply.github.com>
Co-authored-by: Alex Kestner <akestner@users.noreply.github.com>
Co-authored-by: Alex Kestner <akestner@users.noreply.github.com>
|
Thanks! I appreciate the additional info, I was unclear on the impact of this step. |
ellistarn
previously approved these changes
Jul 23, 2021
ellistarn
reviewed
Jul 23, 2021
ellistarn
reviewed
Jul 23, 2021
ellistarn
approved these changes
Jul 23, 2021
ellistarn
added a commit
to ellistarn/karpenter-provider-aws
that referenced
this pull request
Jul 26, 2021
* readd step for tagging subnets * Update website/content/en/docs/getting-started/_index.md Co-authored-by: Alex Kestner <akestner@users.noreply.github.com> * Update website/content/en/docs/getting-started/_index.md Co-authored-by: Alex Kestner <akestner@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Alex Kestner <akestner@users.noreply.github.com> * Update website/content/en/docs/getting-started/_index.md * Update website/content/en/docs/getting-started/_index.md Co-authored-by: Alex Kestner <akestner@users.noreply.github.com> Co-authored-by: Ellis Tarn <ellistarn@gmail.com>
gfcroft
pushed a commit
to gfcroft/karpenter-provider-aws
that referenced
this pull request
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
add step to add cluster name tags to subnet resources
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.