Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started Guide improvements #599

Merged
merged 2 commits into from
Aug 9, 2021
Merged

Getting Started Guide improvements #599

merged 2 commits into from
Aug 9, 2021

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Aug 6, 2021

Issue, if available:

Description of changes:
This change strikes a tradeoff between simplicity and usability. All steps beyond CreateCluster will now work on any EKS cluster, including those that customers have setup beforehand. While this introduces an additional step, it will help avoid commonly seen pitfalls where folks attempt to follow the guide by skipping the CreateCluster step, and inevitably get stuck in permission hell.

  1. If you already have a cluster setup, the IAM association commands will work as expected
  2. If IAM permissions ever change in future versions, users may simply redeploy the cloudformation stack (previously you'd get stuck with eksctl)
  3. Also bumped helm chart version

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Aug 6, 2021

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: fe8ad85

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/610dd2175a69ca00077e31ea

😎 Browse the preview: https://deploy-preview-599--karpenter-docs-prod.netlify.app

@ellistarn
Copy link
Contributor Author

#598

akestner
akestner previously approved these changes Aug 6, 2021
Copy link
Contributor

@akestner akestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking

@ellistarn ellistarn changed the title Bumped getting started to 0.3.0 Getting Started Guide improvements Aug 7, 2021
@ellistarn ellistarn merged commit da282b0 into aws:main Aug 9, 2021
@ellistarn ellistarn deleted the helm branch August 9, 2021 23:55
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants