-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax soft constraints if pods cannot be scheduled #705
Conversation
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 855c58a 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6153a5f3aec65900076de5de |
0ebe5de
to
b183a02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far
0dafcf7
to
a95054f
Compare
a95054f
to
d8a994d
Compare
pod := test.UnschedulablePod() | ||
pod.Spec.Affinity = &v1.Affinity{NodeAffinity: &v1.NodeAffinity{RequiredDuringSchedulingIgnoredDuringExecution: &v1.NodeSelector{NodeSelectorTerms: []v1.NodeSelectorTerm{ | ||
{MatchExpressions: []v1.NodeSelectorRequirement{ | ||
{Key: v1.LabelTopologyZone, Operator: v1.NodeSelectorOpIn, Values: []string{"invalid"}}, // Should not be relaxed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking - it should not be relaxed because it's the last (only) one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. You can't remove all the hard requirements otherwise they wouldn't be very hard =/
ad84ee8
to
419ee38
Compare
@@ -75,6 +75,8 @@ spec: | |||
operator: In | |||
values: | |||
- linux | |||
- key: karpenter.sh/provisioner-name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
419ee38
to
855c58a
Compare
1. Issue, if available:
#417
2. Description of changes:
Useful for:
3. Does this change impact docs?
Testing
deployment.yaml
provisioner.yaml
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.