ignore static pods owned by a node in node emptiness check #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 111773f 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6157356252052e0008756bba |
ellistarn
previously approved these changes
Oct 1, 2021
bwagner5
force-pushed
the
static-pod-emptiness
branch
from
79b32ec
to
111773f
Compare
ellistarn
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
N/A
2. Description of changes:
I ran into a few problems running Karpenter on kOps because kube-proxy is deployed as a static pod. Static pods have owner references to the node resource they are running on. This change checks if a pod is a static pod when performing karpenter's node emptiness check. Static pods shouldn't hold up node eviction since they are effectively an agent similar to a daemonset which karpenter already ignores.
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.