fix yaml download cmds in grafana docs #873
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: cc28acf 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61abf3f5a7d4b80007d16760 😎 Browse the preview: https://deploy-preview-873--karpenter-docs-prod.netlify.app |
|
I thought we decided to delete those? |
I was a bit confused too. I think we removed the specific grafana page, but left it in the getting started guide. We should probably remove for the time being. |
|
@ellistarn You suggested we remove the grafana docs for now. They are not in the pre-docs that we are about to move over for GA. |
| @@ -184,10 +184,10 @@ helm repo update | |||
|
|
|||
| kubectl create namespace monitoring | |||
|
|
|||
| curl -fsSL https://karpenter.sh/docs/getting-started/prometheus-values.yaml | |||
| curl -fsSL https://karpenter.sh/docs/getting-started/prometheus-values.yaml | tee prometheus-values.yaml | |||
There was a problem hiding this comment.
I'm confused - when I try to curl that path I get a 404. Also is tee really needed here? Why isn't curl outputting to the right filename in the first place?
There was a problem hiding this comment.
The files were removed, I've added them back in this PR.
Regarding the tee, I wanted the user to see what they are configuring rather than blindly passing the values files to the helm command.
bwagner5
force-pushed
the
metrics-docs
branch
from
64b910d
to
e9c228e
Compare
bwagner5
force-pushed
the
metrics-docs
branch
from
e9c228e
to
cc28acf
Compare
| helm repo add prometheus-community https://prometheus-community.github.io/helm-charts | ||
| helm repo update | ||
|
|
||
| kubectl create namespace monitoring |
There was a problem hiding this comment.
can we create this in the helm command? --create-namespace
| ```sh | ||
| kubectl get secret --namespace monitoring grafana -o jsonpath="{.data.admin-password}" | base64 --decode | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Is there a curl command that we can run to load the karpenter dashboards into grafana?
1. Issue, if available:
N/A
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.