Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to provide custom resources to the controller from Helm #882

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

prakarsh-dt
Copy link
Contributor

1. Issue, if available:
Fixes #881

2. Description of changes:

  • Exposed controller resources to values.yaml of Helm chart
  • Exposed webhook resources to values.yaml of Helm chart
  • Copied existing resources as recommened/default resources in values.yaml of Helm chart

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- Exposed controller resources to values.yaml
- Exposed webhook resources to values.yaml
- Copied existing resources as recommened/default resources in values.yaml
@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 7a85b43

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61a92a4de4cf65000724e96c

ellistarn
ellistarn previously approved these changes Dec 2, 2021
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@ellistarn
Copy link
Contributor

Resolving the merge conflict for ya.

prateekgogia
prateekgogia previously approved these changes Dec 2, 2021
Copy link
Contributor

@prateekgogia prateekgogia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellistarn ellistarn merged commit 88a9c5a into aws:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to provide custom resources in Helm chart
3 participants