Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Getting Started link to point to the current docs #886

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

sadok-f
Copy link
Contributor

@sadok-f sadok-f commented Dec 1, 2021

1. Issue, if available:

2. Description of changes:
The Getting Started link is pointing to the old version of the docs (v0.4.3-docs), to fix this the file website/content/en/docs/getting-started/_index.md should contains the same menu options as the one in website/content/en/v0.4.3-docs/getting-started/_index.md.
basically adding:

menu:
  main:
    weight: 10

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 6efdabd

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61a76475c4f972000916a245

😎 Browse the preview: https://deploy-preview-886--karpenter-docs-prod.netlify.app

@rothgar
Copy link
Contributor

rothgar commented Dec 1, 2021

Thanks for the PR!

/lgtm

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ellistarn ellistarn merged commit d782e79 into aws:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants