Allow override of webhook port in Helm chart #908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
No issue
2. Description of changes:
This change allows the override of the port used by the webhook deployment when using the Helm chart. This is useful in clusters where the AWS CNI is not used (host networking is required) and we want to ensure pods don't accidentally step on each other's toes if we have other webhook admission controllers. We're specifically mapping the ports used by these controllers to prevent these types of collisions, so having the ability to override the port is quite useful.
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.