Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of webhook port in Helm chart #908

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Allow override of webhook port in Helm chart #908

merged 2 commits into from
Dec 3, 2021

Conversation

mikesir87
Copy link
Contributor

1. Issue, if available:
No issue

2. Description of changes:
This change allows the override of the port used by the webhook deployment when using the Helm chart. This is useful in clusters where the AWS CNI is not used (host networking is required) and we want to ensure pods don't accidentally step on each other's toes if we have other webhook admission controllers. We're specifically mapping the ports used by these controllers to prevent these types of collisions, so having the ability to override the port is quite useful.

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Michael Irwin <mikesir87@gmail.com>
@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 6c3d0b8

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61aa51e9e0175e000715b02c

ellistarn
ellistarn previously approved these changes Dec 3, 2021
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: Michael Irwin <mikesir87@gmail.com>
@ellistarn
Copy link
Contributor

ellistarn commented Dec 3, 2021

@tuananh your helm chart CI checks are already paying dividends :)

@mikesir87
Copy link
Contributor Author

Haha... yeah! I'll have to look at how you're doing that because I know we run into similar problems. Certainly a nice check to have in place.

On another note... I didn't do any bumping of the chart version. I assumed you'd take care of that whenever you do your next release (which looks to be on the same lifecycle as karpenter itself)?

@ellistarn
Copy link
Contributor

Yes -- for now. Planning on cutting a release this afternoon.

@ellistarn
Copy link
Contributor

Haha... yeah! I'll have to look at how you're doing that because I know we run into similar problems. Certainly a nice check to have in place.

Just a simple dirty check that's run on make dev and make ci: https://github.com/aws/karpenter/blob/main/Makefile#L42

@ellistarn ellistarn merged commit 552821f into aws:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants