-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.5.1 #911
v0.5.1 #911
Conversation
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: baf55b6 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61aa70c32f4f0d0008e2f879 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the changes to the Getting Started guide as well?
Hey @tuananh, I found a way to simplify the helm README to just generate I just wanted to check that I'm not missing anything from your change and get your blessing on these changes. |
Let's cut docs in a followon -- it's a bit complicated. |
@ellistarn this works for the current manual release i guess. but later on, if you want to automate the release process of helm chart, it'll get a bit complicated because we then need CI to comit back the changes of helm-docs back which i don't think is a good idea. what i have in mind is
then we can automate the chart release progress, without waiting for karpenter. since i figure chart release is usually a lot more frequent than karpenter itself. |
Good points. Let's cover this in working group. |
Sure can :) |
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.