Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.1 #911

Merged
merged 1 commit into from
Dec 3, 2021
Merged

v0.5.1 #911

merged 1 commit into from
Dec 3, 2021

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: baf55b6

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61aa70c32f4f0d0008e2f879

Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the changes to the Getting Started guide as well?

@ellistarn
Copy link
Contributor Author

ellistarn commented Dec 3, 2021

Hey @tuananh, I found a way to simplify the helm README to just generate helm-docs whenever we run make helm. Since chart is published alongside release versions, we only want to update the README when we release a new version of the chart. This is important to avoid version skew.

I just wanted to check that I'm not missing anything from your change and get your blessing on these changes.

@ellistarn
Copy link
Contributor Author

Can you make the changes to the Getting Started guide as well?

Let's cut docs in a followon -- it's a bit complicated.

@ellistarn ellistarn merged commit aabe481 into aws:main Dec 3, 2021
@ellistarn ellistarn deleted the release branch December 3, 2021 19:45
@tuananh
Copy link
Contributor

tuananh commented Dec 4, 2021

@ellistarn this works for the current manual release i guess. but later on, if you want to automate the release process of helm chart, it'll get a bit complicated because we then need CI to comit back the changes of helm-docs back which i don't think is a good idea.

what i have in mind is

  • check helm-docs for every pr
  • make sure the chart version bump is getting check too.

then we can automate the chart release progress, without waiting for karpenter. since i figure chart release is usually a lot more frequent than karpenter itself.

@ellistarn
Copy link
Contributor Author

@ellistarn this works for the current manual release i guess. but later on, if you want to automate the release process of helm chart, it'll get a bit complicated because we then need CI to comit back the changes of helm-docs back which i don't think is a good idea.

what i have in mind is

  • check helm-docs for every pr
  • make sure the chart version bump is getting check too.

then we can automate the chart release progress, without waiting for karpenter. since i figure chart release is usually a lot more frequent than karpenter itself.

Good points. Let's cover this in working group.

@tuananh
Copy link
Contributor

tuananh commented Dec 4, 2021

Sure can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants