-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile for build a self-containing container image #27
Conversation
Thank you for your contribution @yubingjiaocn . We will take a look and get back to you. |
Thank you for adding instruction and testing for this PR. I also added support for customize generated binary file name. Now the dockerfile can better handling for multiple arch and OS. |
Is there any chance to re-run the build test? I see the error message and believes it's because Github shared runner hits ECR's limit of
|
Tested porting-advisor-for-graviton as a Docker container end to end on local machine. |
Description of change
Add a Dockerfile so user can build self-containing container image. User can use this image on any Linux instance without need of Python or Java runtime.
Issue
#26
PR reviewer notes
This Dockerfile contains multiple runtimes (Python, Java and Maven). I left all install command in Dockerfile so it may be poorly formatted.
I have built a image and stored in
public.ecr.aws/bingjiao/porting-advisor-for-graviton:main
(x86-64 only)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.