Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for build a self-containing container image #27

Merged
merged 9 commits into from
Jun 20, 2023
Merged

Add Dockerfile for build a self-containing container image #27

merged 9 commits into from
Jun 20, 2023

Conversation

yubingjiaocn
Copy link
Contributor

Description of change

Add a Dockerfile so user can build self-containing container image. User can use this image on any Linux instance without need of Python or Java runtime.

Issue

#26

PR reviewer notes

This Dockerfile contains multiple runtimes (Python, Java and Maven). I left all install command in Dockerfile so it may be poorly formatted.

I have built a image and stored in public.ecr.aws/bingjiao/porting-advisor-for-graviton:main (x86-64 only)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jamolina
Copy link
Contributor

Thank you for your contribution @yubingjiaocn . We will take a look and get back to you.

jamolina
jamolina previously approved these changes Jun 16, 2023
jamolina
jamolina previously approved these changes Jun 16, 2023
@yubingjiaocn
Copy link
Contributor Author

yubingjiaocn commented Jun 17, 2023

Thank you for adding instruction and testing for this PR. I also added support for customize generated binary file name. Now the dockerfile can better handling for multiple arch and OS.
I think this PR is good to go from my side.

@yubingjiaocn
Copy link
Contributor Author

yubingjiaocn commented Jun 19, 2023

Is there any chance to re-run the build test? I see the error message and believes it's because Github shared runner hits ECR's limit of Rate of unauthenticated image pulls , which is only 1 pulls per second.

Step 8/10 : FROM public.ecr.aws/amazoncorretto/amazoncorretto:17-al2023 as runtime
17-al2023: Pulling from amazoncorretto/amazoncorretto
toomanyrequests: Rate exceeded

@as14692
Copy link
Contributor

as14692 commented Jun 20, 2023

Tested porting-advisor-for-graviton as a Docker container end to end on local machine.

@as14692 as14692 merged commit 4a56af7 into aws:main Jun 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants