Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Python version check when running as a script #49

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

natict
Copy link
Contributor

@natict natict commented Apr 1, 2024

Description of change

When running as a script, even on current AL2/AL2023 porting advisor fails with an exception due to old Python version installed by default. This change will print a descriptive message in such cases which will help users who missed the prerequisite in the Readme.md

Issue

#48

PR reviewer notes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@otterley
Copy link
Collaborator

otterley commented Apr 1, 2024

LGTM 🚢

Copy link
Contributor

@jamolina jamolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for your contribution!

@jamolina jamolina merged commit d8c4e12 into aws:main Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants