Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing FakeDependency #50

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Removing FakeDependency #50

merged 1 commit into from
Apr 8, 2024

Conversation

Beau-Gosse-dev
Copy link
Contributor

Description of change

[//]: # Removing FakeDependency since it's not a real dependency

Issue

[//]: # Internal issue P125404734

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Beau-Gosse-dev Beau-Gosse-dev self-assigned this Apr 8, 2024
@Beau-Gosse-dev Beau-Gosse-dev marked this pull request as draft April 8, 2024 22:35
Copy link
Contributor

@as14692 as14692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests will have to be updated as well. Try removing

  1. "<si><t>FakeDependency</t></si><si><t>1.2.3</t></si>"
  2. "<si><t>FakeDependency</t></si><si><t>1.2.3</t></si>"

@Beau-Gosse-dev Beau-Gosse-dev marked this pull request as ready for review April 8, 2024 23:18
@Beau-Gosse-dev Beau-Gosse-dev merged commit 9dc5f23 into main Apr 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants