fix for index arithmetic #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Is it possible to add tests to verify and prevent regressions? |
|
I believe that the existing code can throw an NPE. Given that we are still in alpha, there is no existing test coverage for the extrapolation methods, and writing unit tests for the extrapolate methods will require some finicky mocking, I'm inclined to merge this PR as is and create a new Issue to add test coverage. Does that work for you @wnbts ? |
|
OK |
|
Issue to add test coverage #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: The extrapolation code for the cyclic case had incorrect index arithmetic
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.