transport: wire up the default pacer #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark report |
camshaft
approved these changes
Dec 6, 2021
| @@ -140,6 +141,7 @@ pub struct CubicCongestionController { | |||
| //# slow start [RFC3742] or hybrid slow start [HR08] for fast and long- | |||
| //# distance networks. | |||
| slow_start: HybridSlowStart, | |||
| pacer: Pacer, | |||
There was a problem hiding this comment.
Do you anticipate there being multiple implementations of a pacer? Will there be any configuration for pacers?
There was a problem hiding this comment.
At this point I'm just thinking of the default Pacer and the pacer that BBR uses. No configuration yet, though we can revisit that
WesleyRosenblum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #146
Description of changes: This change wires up the default packet pacer into the Cubic congestion controller. I've also added a
earliest_departure_timemethod to the CongestionController trait.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.