feat(s2n-quic-dc): add socket constructor #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/cbpf
branch
2 times, most recently
from
8de3cab
to
bd45859
Compare
camshaft
force-pushed
the
camshaft/cbpf
branch
2 times, most recently
from
187ece8
to
3926e68
Compare
dc/s2n-quic-dc/src/socket/pair.rs
Outdated
| // have the OS select a random port for us | ||
| options.addr.set_port(0); | ||
| // don't reuse the ports since we don't have a consistent way to route packets | ||
| options.reuse_port = Default::default(); |
There was a problem hiding this comment.
nit: It's a little more readable to me if you say options.reuse_port = ReusePort::Disabled
WesleyRosenblum
previously approved these changes
Jun 11, 2024
WesleyRosenblum
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a mechanism to easily construct UDP and TCP sockets with a
socket::Optionsstruct. I've also included an in-memory BPF assembler, which enables creating pairs of UDP sockets and route packets between them.Testing:
Several tests were added as part of these changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.