feat(s2n-quic-core): updates to dc provider #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
dc provider implementations need to know if the local endpoint is a server or a client. This change adds that information to the
dc::ConnectionInfopassed to the provider.Also, the
on_path_secrets_readymethod may have reason to fail (such as if the given path secrets are using a cipher suite not supported by the provider implementation). This change makes that method fallible.Testing:
Updated unit test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.