Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ak tls name2 #674

Closed
wants to merge 4 commits into from
Closed

Ak tls name2 #674

wants to merge 4 commits into from

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Jun 1, 2021

Issue #, if available:

Description of changes:
Since we have reserved the crate https://crates.io/crates/s2n-tls on crates.io we need to change the name of the internal submodule crate.

This is a work around and we will drop the internal crate once we start publishing s2n-tls rust bindings to crates.io

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@camshaft
Copy link
Contributor

camshaft commented Jun 1, 2021

This should be a patch as part of the import script, not in the official repo. We should really try and get those bindings published instead and then we can just delete this crate entirely

@toidiu
Copy link
Contributor Author

toidiu commented Jun 1, 2021

agreed that we should publish the bindings and just use those. this was meant as a quick work around in the meantime to unblock clients.

Also +1 to the patch

@toidiu
Copy link
Contributor Author

toidiu commented Jun 1, 2021

this pr fails CI: https://github.com/awslabs/s2n-quic/pull/674/checks?check_run_id=2723362292 and i think we need to do a git submodule update --init to solve it.. that what i needed to do locally

will we need to do that each time of am i missing some additional step?

@dougch
Copy link
Contributor

dougch commented Jun 2, 2021

agreed that we should publish the bindings and just use those. this was meant as a quick work around in the meantime to unblock clients.

Isn't using a cargo local over-ride easier? https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html

@dougch
Copy link
Contributor

dougch commented Jun 2, 2021

agreed that we should publish the bindings and just use those. this was meant as a quick work around in the meantime to unblock clients.

Isn't using a cargo local over-ride easier? https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html

Turns out overrides are at the registry level, not per crate. Based on comments in cargo/issues/6713 single crate path over-rides aren't currently supported.

@toidiu toidiu closed this Jun 22, 2021
@toidiu toidiu deleted the ak-tls_name2 branch June 22, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants