Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S2N_RESULT to a couple functions. #2371

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Conversation

rday
Copy link
Contributor

@rday rday commented Nov 9, 2020

Description of changes:

On going ops work to move to the S2N_RESULT pattern.

Testing:

This is a refactor change. Testing includes local test runs and the standard CI.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #2371 (e45e64c) into main (efbb48b) will increase coverage by 6.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
+ Coverage   81.84%   87.87%   +6.03%     
==========================================
  Files         268      166     -102     
  Lines       18300    14066    -4234     
==========================================
- Hits        14978    12361    -2617     
+ Misses       3322     1705    -1617     

Impacted file tree graph

Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@rday rday merged commit 5f8faed into aws:main Nov 11, 2020
@rday rday deleted the s2n_result_updates branch November 11, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants