Audit connection bitfield for thread safety #4036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
threads
branch
2 times, most recently
from
67bb4d0
to
cf221b9
Compare
|
This PR has gotten a bit unfocused / disjointed. I'm going to split out some of the less relevant changes. |
Is there an issue for this? |
maddeleine
reviewed
Jun 6, 2023
lrstewart
force-pushed
the
threads
branch
2 times, most recently
from
03ee173
to
08da3d0
Compare
camshaft
approved these changes
Jun 14, 2023
| @@ -223,7 +223,7 @@ int main(int argc, char **argv) | |||
| EXPECT_SUCCESS(s2n_stuffer_growable_alloc(&stuffer, 0)); | |||
| EXPECT_SUCCESS(s2n_connection_set_io_stuffers(&stuffer, &stuffer, client_conn)); | |||
|
|
|||
| client_conn->key_update_pending = true; | |||
| client_conn->key_update_pending = 1; | |||
There was a problem hiding this comment.
nit: Is this change needed? I tend to prefer bools for flags as it indicates the intent better, rather than it being just some arbitrary number.
|
I've been moving the changes from this PR into other PRs. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #4026
Description of changes:
I went through the bitfield in s2n_connection and pulled out the two variables set post-handshake. I also added more documentation to make the situation clearer.
Testing:
Existing tests pass.
I also added a new test that runs with separate threads for send and receive. When run with ThreadSanitizer, it detected the issues fixed in this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.