Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: Skip the sslyze test on arm #4050

Merged
merged 4 commits into from
Jun 27, 2023
Merged

nix: Skip the sslyze test on arm #4050

merged 4 commits into from
Jun 27, 2023

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Jun 12, 2023

Resolved issues:

n/a

Description of changes:

Skip running the sslyze integration test under nix and aarch64-linux. This should be the last nix related PR before we can start running integrations tests on aarch64-linux.

Call-outs:

  • sslyze was included in nixpkgs 2021.11, but was removed.
  • We don't need tox; nix is filling the role of a virtualenv builder.
  • We don't need to pin to old versions of pytest/xdist (unless someone knows better).
  • Tests from previous revisions of this PR moved to Dev shell tests with pytest #4062

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? local and CI

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jun 12, 2023
@dougch dougch marked this pull request as ready for review June 13, 2023 18:41
@dougch dougch requested review from toidiu and lrstewart June 13, 2023 18:42
CMakeLists.txt Outdated Show resolved Hide resolved
nix/shell.sh Outdated Show resolved Hide resolved
nix/shell.sh Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@dougch dougch marked this pull request as draft June 16, 2023 16:17
@dougch dougch marked this pull request as ready for review June 16, 2023 23:07
@dougch dougch requested a review from lrstewart June 16, 2023 23:07
@dougch dougch changed the title Sslyze skip nix: Skip the sslyze test on arm Jun 16, 2023
@dougch dougch requested a review from goatgoose June 21, 2023 21:52
ps.typing-extensions
ps.setuptools-rust
ps.cryptography
] ++ (if pkgs.stdenv.hostPlatform.system == "x86_64-linux" then [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sslyze test seems to run for every platform except aarch64, but the sslyze dependency is installed only on linux x86_64. Is there any concern about running the integ tests on a platform other than aarch64 or linux x86-64? Like, if you were to try and run the integ tests on mac, would it attempt to run sslyze but fail because the dependency isn't installed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being cautious here, the other possible platform that might get these packages is x86_64-darwin, which we'll add when doing the darwin nix work. If the dependency can't be installed, the devShell won't even start.

@dougch dougch requested a review from goatgoose June 26, 2023 20:06
@dougch dougch enabled auto-merge (squash) June 27, 2023 16:26
@dougch dougch merged commit 5d7925f into aws:main Jun 27, 2023
27 checks passed
tinzh pushed a commit to tinzh/s2n-tls that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants