Add API to retrieve the supported groups for a security policy #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
force-pushed
the
config-supported-groups
branch
12 times, most recently
from
55b206f
to
e319a94
Compare
goatgoose
force-pushed
the
config-supported-groups
branch
from
e319a94
to
fbf5e5d
Compare
maddeleine
reviewed
Nov 3, 2023
goatgoose
force-pushed
the
config-supported-groups
branch
from
ffce860
to
1b876fa
Compare
maddeleine
reviewed
Nov 10, 2023
goatgoose
force-pushed
the
config-supported-groups
branch
from
f5c264f
to
db78332
Compare
goatgoose
force-pushed
the
config-supported-groups
branch
from
db78332
to
7c2b7c4
Compare
maddeleine
approved these changes
Nov 10, 2023
lrstewart
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a new API that gets a list of all the supported groups for a given config's security policy. The API can be used for logging, and to compare the server's supported groups with the client's supported groups with the
s2n_client_hello_get_supported_groups()API.Call-outs:
I tried to refactor the supported groups send so that the same logic could be used for the new API, but it ended up being a lot more complex than just having additional for loops for the kem and curve preferences. I think it's difficult because the extension needs to write to a stuffer and has to make decisions based on the protocol version (and potentially other connection fields in the future), and the API just needs to populate an array with all of the groups. If I'm missing something with this though and there should be a clean way to do this let me know.
Testing:
New unit tests for the API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.