bench: increase cert chain length #4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most commonly aws service retain a 3 certificate chain, with a leaf cert, intermediate CA, and root CA. This commit updates our benchmarking configuration to reflect that.
maddeleine
approved these changes
Nov 14, 2023
toidiu
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Most public AWS services have cert chains with 3 certificates. A trusted root, an untrusted intermediate, and an untrusted server certificate. Our benchmarking setup should be adjusted to reflect this more common case.
This commit increases the cert chain length. In the process, it also removes the dependence on config files from the
generate-certs.shscript. Finally it adds P-256 certs to the benchmarking harness.Callouts:
My editor automatically removes trailing whitespace, so the diff is a little messy.
Testing:
The unit tests automatically cover all of the enum types, so the new certificates are covered under the existing unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.