ktls: add TLS1.3 support #4314
Merged
ktls: add TLS1.3 support #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
ktls_tls13_1
branch
from
2aaa8ac
to
282e8e4
Compare
camshaft
requested changes
Dec 11, 2023
lrstewart
force-pushed
the
ktls_tls13_1
branch
from
264d700
to
18acee6
Compare
camshaft
approved these changes
Dec 11, 2023
goatgoose
reviewed
Dec 11, 2023
goatgoose
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Related to #3711
Description of changes:
Adds minimal support for TLS1.3 in ktls by deriving the key using the TLS1.3 method and configuring AES according to the TLS1.3 rules.
Call-outs:
This PR does NOT enable TLS1.3 support outside of testing. Because of KeyUpdates, TLS1.3 with ktls is more risky than TLS1.2 with ktls, so we might want a new config method added to the unstable API to explicitly enable it.
This PR does NOT add support for KeyUpdate or key limits. We can't update the keys without a kernel patch. However, we can fail more explicitly when a KeyUpdate is encountered, and we can probably enforce estimates of key limits. Those improvements will be made in a follow-up PR.
Testing:
The self-talk tests using TLS1.3 pass, proving that we've configuring the keys and ivs correctly.
I tested that the updated feature probe fails in both cmake and make if I change TLS_1_3_VERSION to TLS_1_4_VERSION.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.