test: additional test certs #4378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a previous issue with the signature in the rsae-pss certs. It also adds more hash digest coverage.
maddeleine
reviewed
Jan 25, 2024
| @@ -168,6 +169,9 @@ then | |||
| cert-gen ec ecdsa 384 SHA256 ec_ecdsa_p384_sha256 | |||
| cert-gen ec ecdsa 384 SHA384 ec_ecdsa_p384_sha384 | |||
| cert-gen ec ecdsa 521 SHA384 ec_ecdsa_p521_sha384 | |||
| cert-gen ec ecdsa 521 SHA512 ec_ecdsa_p521_sha512 | |||
| cert-gen rsa pkcsv1.5 2048 SHA1 rsae_pkcs_2048_sha1 | |||
There was a problem hiding this comment.
Kind of a nit, we usually specify which pkcs padding is used in the filename. Otherwise pkcs doesn't really have much meaning on its own.
There was a problem hiding this comment.
Mostly the purpose of this is to iterate over the different NID's so pkvs vs pss is enough for my test purposes, but it sounds like a nice future item to add support for different pkcs padding choices.
maddeleine
approved these changes
Jan 25, 2024
goatgoose
approved these changes
Jan 25, 2024
- fix intermediate CA typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
signature_optionswhen generating the intermediate certTesting:
Rebased my in-development unit tests on top of this as well as manual inspection using the
openssl x509utility.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.