feat: Server name getter for client hello #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
commented
Feb 1, 2024
maddeleine
requested review from
goatgoose,
jmayclin and
camshaft
and removed request for
lrstewart,
camshaft and
jmayclin
camshaft
reviewed
Feb 6, 2024
jmayclin
reviewed
Feb 6, 2024
maddeleine
force-pushed
the
server_name
branch
from
a0df702
to
8d57f83
Compare
maddeleine
requested review from
jmayclin and
camshaft
and removed request for
goatgoose
lrstewart
reviewed
Feb 9, 2024
jmayclin
reviewed
Feb 9, 2024
maddeleine
force-pushed
the
server_name
branch
from
48bcbd2
to
03bf3db
Compare
lrstewart
reviewed
Feb 12, 2024
lrstewart
approved these changes
Feb 14, 2024
jmayclin
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4308
Description of changes:
Adds some new APIs to get the server name off of a parsed client hello. Note that we already have a get_server_name function, but it requires access to a connection struct. Therefore, if we want the server name to be available for someone solely using s2n-tls as a "client hello parsing library", we need this client hello getter.
Call-outs:
Testing:
Includes tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.