Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cert chain with mixed key sizes #4433

Merged
merged 4 commits into from Feb 22, 2024

Conversation

jmayclin
Copy link
Contributor

This commit adds a "mixed key" chain where the CA is using a smaller key than all of the other certs in the chain.

Description of changes:

This is needed for test cases for the cert key preference feature.

Testing:

I rebased the cert key preferences PR on top of this branch and made sure that all the tests passed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This commit adds a "mixed key" chain where the CA is using a smaller key
than all of the other certs in the chain.
@github-actions github-actions bot added the s2n-core team label Feb 21, 2024
@jmayclin jmayclin marked this pull request as ready for review February 21, 2024 08:59
tests/pems/mixed_chains/generate-certs.sh Outdated Show resolved Hide resolved
tests/pems/mixed_chains/generate-certs.sh Outdated Show resolved Hide resolved
jmayclin and others added 2 commits February 21, 2024 10:55
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
- correct comment
@jmayclin jmayclin enabled auto-merge (squash) February 22, 2024 04:49
@jmayclin jmayclin merged commit a9a3f8c into aws:main Feb 22, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants